Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skip_noisy_assignment to dataset.cluster #1194

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Add skip_noisy_assignment to dataset.cluster #1194

merged 3 commits into from
Feb 28, 2024

Conversation

dsmilkov
Copy link
Collaborator

@dsmilkov dsmilkov commented Feb 28, 2024 •
edited
Loading

When skip_noisy_assignment=True, we skip an expensive step for assigning noisy points to nearest clusters. It's only effectively when running locally.

nsthorat
nsthorat approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woop

lilac/data/clustering.py Show resolved Hide resolved
lilac/data/dataset.py Show resolved Hide resolved
@dsmilkov dsmilkov enabled auto-merge (squash) February 28, 2024 17:20
@dsmilkov dsmilkov merged commit f74d88d into main Feb 28, 2024
4 checks passed
@dsmilkov dsmilkov deleted the ds-skip-noisy branch February 28, 2024 17:25
@dsmilkov dsmilkov mentioned this pull request Feb 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsthorat nsthorat nsthorat approved these changes

@brilee brilee Awaiting requested review from brilee

Assignees
No one assigned
Labels
backend client lib frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsmilkov @nsthorat